Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update highlight.js to 10.1.2 #36309

Merged
merged 1 commit into from
Nov 30, 2020
Merged

tools: update highlight.js to 10.1.2 #36309

merged 1 commit into from
Nov 30, 2020

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 28, 2020
@MylesBorins
Copy link
Contributor Author

Can we please fast-track

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 28, 2020
@MylesBorins MylesBorins mentioned this pull request Nov 28, 2020
Closed
@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34602/

@Trott
Copy link
Member

Trott commented Nov 29, 2020 •
edited
Loading

I ran make doc-only with and without this change (after running npm ci in the relevant directory) and there was no change to the resulting docs, so that's good.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34614/

@benjamingr
Copy link
Member

Looks good the CI was stuck and ran for 14 hours so I kicked off a new one

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34622/

@MylesBorins @Trott
tools: update highlight.js to 10.1.2
f34866a 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: nodejs#36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 30, 2020

Landed in f34866a

@Trott Trott merged commit f34866a into nodejs:master Nov 30, 2020
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@MylesBorins @danielleadams
tools: update highlight.js to 10.1.2
d95ae65 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: #36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@MylesBorins @cjihrig
tools: update highlight.js to 10.1.2
08caf8d 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: nodejs#36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@MylesBorins @targos
tools: update highlight.js to 10.1.2
2677fe9 
Refs: GHSA-vfrc-7r7c-w9mx

PR-URL: #36309
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MylesBorins @nodejs-github-bot @Trott @benjamingr @aduh95