Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,lib,test: change whitelist to allowlist #36406

Closed
wants to merge 1 commit into from
Closed

build,lib,test: change whitelist to allowlist #36406

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 6, 2020

No description provided.

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 6, 2020
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34789/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34793/

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34829/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34885/

@richardlau richardlau mentioned this pull request Dec 10, 2020
Closed
3 tasks
mhdawson
mhdawson approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34893/

@mhdawson
Copy link
Member

Resume build - https://ci.nodejs.org/job/node-test-pull-request/34893/

@mhdawson
Copy link
Member

Build good landing

@mhdawson
Copy link
Member

Landed in 7e5bf48

@mhdawson mhdawson closed this Dec 11, 2020
mhdawson pushed a commit that referenced this pull request Dec 11, 2020
@targos @mhdawson
build,lib,test: change whitelist to allowlist
7e5bf48 
PR-URL: #36406
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos deleted the allowlist branch December 11, 2020 05:54
targos added a commit that referenced this pull request Dec 21, 2020
@targos
build,lib,test: change whitelist to allowlist
1330995 
PR-URL: #36406
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos added a commit that referenced this pull request May 1, 2021
@targos
build,lib,test: change whitelist to allowlist
9ccf7db 
PR-URL: #36406
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @mhdawson @Trott @addaleax @lpinca @cjihrig