doc: add a remark to Collaborators discussion page #36420
Conversation
nodejs-github-bot
added
the
meta
GOVERNANCE.md
Outdated
| frictionless as possible. Use the [Collaborators discussion page][](only | ||
| Collaborators have permissions to view) to request |
There was a problem hiding this comment.
Maybe this instead?:
| frictionless as possible. Use the [Collaborators discussion page][](only | |
| Collaborators have permissions to view) to request | |
| frictionless as possible. Use the private [Collaborators discussion page][] | |
| to request |
Is "private" sufficiently clear in this case?
There was a problem hiding this comment.
Sorry. I don't think so. It will make me feel confused when I read private. I think my remark is more clear than private.
There was a problem hiding this comment.
I think my remark is more clear than
private.
That's true. What you wrote is more clear than my suggestion.
What I was trying to avoid was separating "Use the Collaborators discussion board" from what to use it for: "to request feedback from other Collaborators in private."
Current sentence: "Use the Collaborators discussion board to request feedback from other Collaborators in private."
With change here: "Use the Collaborators discussion board (only Collaborators have permissions to view) to request feedback from other Collaborators in private."
I feel like that makes the resulting sentence harder to understand.
How about this?:
Use the Collaborators discussion board to requeist feedback from other Collaborators in private. Only Collaborators can view the private discussion board.
Or maybe this?:
To request feedback from other Collaborators in private, use the Collaborators discussion board (which only Collaborators may view).
I'm open to other ideas if these suggestions are no good. I'm also OK if this lands as-is, but I do prefer to not have a parenthetical clause as an aside in the middle of the sentence.
There was a problem hiding this comment.
Thank you for your advice. I think the second idea is pretty good.
PR-URL: nodejs#36420 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
doc_governance
branch
from
3fb7442
to
bea2252
Compare
|
Landed in bea2252 |
PR-URL: #36420 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36420 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add a remark to
Collaborators discussion page. refer to: #36335Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes