-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: refactor to use more primordials in internal/freelist.js #36565
base: main
Are you sure you want to change the base?
Conversation
The benchmark CI regression is quite significant:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
freelist is simple data structure, so refactoring to primordials causes a significant performance regression. I tried some solutions, but they didn't work. Do you all have any ideas about this issue? @aduh95 |
I’m going to try implementing |
I’ve now opened #36600, which implements |
Reference
The file is used here:
node/lib/_http_common.js
Line 34 in b49145f
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes