Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use validateNumber #36993

Closed
wants to merge 1 commit into from
Closed

lib: refactor to use validateNumber #36993

wants to merge 1 commit into from

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Jan 19, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. crypto Issues and PRs related to the crypto subsystem. net Issues and PRs related to the net subsystem. labels Jan 19, 2021
aduh95
aduh95 approved these changes Jan 19, 2021
View reviewed changes
lib/internal/crypto/util.js Outdated Show resolved Hide resolved
@Lxxyx Lxxyx force-pushed the refactor-to-use-validate-number branch from 98480ae to 13bca3c Compare January 19, 2021 11:28
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35633/

lpinca
lpinca approved these changes Jan 19, 2021
View reviewed changes
lib/internal/histogram.js Outdated Show resolved Hide resolved
@Lxxyx Lxxyx force-pushed the refactor-to-use-validate-number branch from 13bca3c to b6ceabb Compare January 20, 2021 14:09
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35643/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35645/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35647/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35686/

jasnell pushed a commit that referenced this pull request Jan 23, 2021
@Lxxyx @jasnell
lib: refactor to use validateNumber
e884fd7 
PR-URL: #36993
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 23, 2021

Landed in e884fd7

@jasnell jasnell closed this Jan 23, 2021
@Lxxyx Lxxyx deleted the refactor-to-use-validate-number branch January 23, 2021 03:55
targos pushed a commit that referenced this pull request Feb 2, 2021
@Lxxyx @targos
lib: refactor to use validateNumber
a29da64 
PR-URL: #36993
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. crypto Issues and PRs related to the crypto subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Lxxyx @nodejs-github-bot @jasnell @lpinca @aduh95 @RaisinTen @PoojaDurgad @targos