Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve security text in collaborators guide #38107

Closed
wants to merge 1 commit into from
Closed

doc: improve security text in collaborators guide #38107

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 6, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 6, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 6, 2021
@jasnell
Copy link
Member

jasnell commented Apr 6, 2021

There's no reason to make this one wait the 48 hours to land. Please 👍🏻 to fast-track

jasnell pushed a commit that referenced this pull request Apr 6, 2021
@Trott @jasnell
doc: improve security text in collaborators guide
005ebaf 
PR-URL: #38107
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 6, 2021

Landed in 005ebaf

@jasnell jasnell closed this Apr 6, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: improve security text in collaborators guide
ecc8551 
PR-URL: #38107
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@Trott Trott deleted the concise-security branch September 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @evanlucas @aduh95 @RaisinTen @nodejs-github-bot