Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] fs: validate fds as int32s #38195

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] fs: validate fds as int32s #38195

wants to merge 1 commit into from

Conversation

Ayase-252
Copy link
Member

Original Commit

This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: https://github.com/nodejs/node/pull/28984
Fixes: https://github.com/nodejs/node/issues/28980
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

Fixes: #37912
Fixes: #38092
Fixes: #38193

@cjihrig @Ayase-252
fs: validate fds as int32s
1539bc2 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: nodejs#28984
Fixes: nodejs#28980
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v10.x labels Apr 11, 2021
@targos
Copy link
Member

targos commented Apr 11, 2021

Thanks for opening this, @Ayase-252. We do not have any more v10.x release scheduled before EoL (at the end of this month), so I cannot guarantee you that it will land.

@Ayase-252
Copy link
Member Author

It's all right, close accordingly.

@Ayase-252 Ayase-252 closed this Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ayase-252 @targos @nodejs-github-bot @cjihrig