src: Use %progbits instead of @progbits #38312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: nodejs#17933 Related: nodejs#37688 Signed-off-by: Stephen Gallagher <[email protected]>
nodejs-github-bot
added
c++
richardlau
approved these changes
Apr 20, 2021
jasnell
approved these changes
Apr 20, 2021
cjihrig
approved these changes
Apr 20, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
author ready
targos
pushed a commit
that referenced
this pull request
Apr 27, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <[email protected]> PR-URL: #38312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 47207e5 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <[email protected]> PR-URL: #38312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <[email protected]> PR-URL: #38312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <[email protected]> PR-URL: #38312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <[email protected]> PR-URL: #38312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <[email protected]> PR-URL: #38312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
sipwise-jenkins
pushed a commit
to sipwise/rtpengine
that referenced
this pull request
Mar 27, 2023
ref: nodejs/node#38312 Change-Id: Ib231e6d1499432701ca6d08ecc5efa5d765ce5ac
sipwise-jenkins
pushed a commit
to sipwise/rtpengine
that referenced
this pull request
Mar 27, 2023
ref: nodejs/node#38312 Change-Id: Ib231e6d1499432701ca6d08ecc5efa5d765ce5ac (cherry picked from commit e80d380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While @progbits is preferred for most architectures, there are some
(notably 32-bit ARM) for which it does not. %progbits is effective
everywhere.
See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more
details.
Related: #17933
Related: #37688
Signed-off-by: Stephen Gallagher [email protected]
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.