Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: enable linter on internal/inspector/inspect_client #38417

Merged
merged 1 commit into from
May 3, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 26, 2021

No description provided.

@github-actions github-actions bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 26, 2021
@aduh95 aduh95 requested a review from Trott April 28, 2021 14:10
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 2, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented May 3, 2021

Landed in 2c0fd32

@aduh95 aduh95 merged commit 2c0fd32 into nodejs:master May 3, 2021
@aduh95 aduh95 deleted the inspect_client-linter branch May 3, 2021 11:58
targos pushed a commit that referenced this pull request May 3, 2021
@targos targos mentioned this pull request May 3, 2021
aduh95 added a commit to aduh95/node that referenced this pull request Jul 19, 2021
@richardlau
Copy link
Member

Backport to v14.x PR: #39446

aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
richardlau pushed a commit that referenced this pull request Jul 22, 2021
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau richardlau mentioned this pull request Jul 22, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38417
Backport-PR-URL: nodejs#39446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants