url,src: simplify ipv6 logic by using uv_inet_pton #38842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
XadillaX
changed the title
addaleax
reviewed
May 29, 2021
XadillaX
changed the title
XadillaX
changed the title
addaleax
approved these changes
May 30, 2021
src/node_url.cc
Outdated
| @@ -78,7 +81,7 @@ class URLHost { | |||
| union Value { | |||
| std::string domain_or_opaque; | |||
| uint32_t ipv4; | |||
| uint16_t ipv6[8]; | |||
| uint16_t ipv6[NS_IN6ADDRSZ / NS_INT16SZ]; | |||
There was a problem hiding this comment.
I think just 8 was a bit clearer here, to be honest…
There was a problem hiding this comment.
There was a problem hiding this comment.
I don’t think glibc is the gold standard for code readability here.
There was a problem hiding this comment.
I've changed it back.🐣
jasnell
reviewed
May 31, 2021
| memset(buf, 0, sizeof(buf)); | ||
| memcpy(*ipv6, input, sizeof(const char) * length); | ||
|
|
||
| int ret = uv_inet_pton(AF_INET6, *ipv6, buf); |
There was a problem hiding this comment.
In theory I'm +1 but we need to make sure that uv_inet_pton matches what the url standard expects here. The reason for the more complicated implementation is that it's what the standard spec specifically calls out.
There was a problem hiding this comment.
- It passes wpt;
uv_inet_ntopandinet_ntopbreaksURLHost::ToString()because it does not match web standard...:x.x.x.x. So I do not modify logic by using*_ntop.
XadillaX
added a commit
that referenced
this pull request
Jun 10, 2021
PR-URL: #38842 Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in c109a6c |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38842 Reviewed-By: Anna Henningsen <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
PR-URL: #38842 Reviewed-By: Anna Henningsen <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
PR-URL: #38842 Reviewed-By: Anna Henningsen <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #38842 Reviewed-By: Anna Henningsen <[email protected]>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38842 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.