Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: revise async iterator usage to comply with lint rules #38847

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented May 29, 2021

I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

@github-actions github-actions bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels May 29, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I guess... but it's pretty weird. Perhaps add a comment about this isn't just using for await?

I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: nodejs#38847
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott merged commit fc264df into nodejs:master Jun 2, 2021
@Trott
Copy link
Member Author

Trott commented Jun 2, 2021

Landed in fc264df

@Trott Trott deleted the datenow branch June 2, 2021 02:48
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: #38847
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 2, 2021
@richardlau
Copy link
Member

This doesn't land cleanly on v14.x-staging. If it shouldn't land, please adjust the labels accordingly.

@Trott
Copy link
Member Author

Trott commented Jul 16, 2021

This doesn't land cleanly on v14.x-staging. If it shouldn't land, please adjust the labels accordingly.

This will cherry-pick cleanly if you land #38811 first. Again, you'll have to be OK with landing primordials for the node inspect stuff. Hopefully, that's an exception you're willing to make on the "no new primordials in v14.x for now" policy.

Cherry-picking in this order all lands cleanly on v14.x-staging as of this writing:

git cherry-pick bdb6c59
git cherry-pick ea47bd2
git cherry-pick f331a18
git cherry-pick f1cbaea
git cherry-pick fc264df

@richardlau
Copy link
Member

@Trott #38406 uses timers/promises which doesn't exist in Node.js 14.x.

=== release test-code-cache ===
Path: parallel/test-code-cache
internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:226:10)
    at loadNativeModule (internal/modules/cjs/helpers.js:39:9)
    at Function.Module._load (internal/modules/cjs/loader.js:761:15)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:92:18)
    at Object.<anonymous> (/home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-code-cache.js:19:3)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
Command: out/Release/node --expose-internals /home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-code-cache.js
=== release test-debug-usage ===
Path: parallel/test-debug-usage
assert.js:406
    throw err;
    ^

AssertionError [ERR_ASSERTION]: (node:3341062) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)
 did not match /Usage: .*node.* debug script\.js\r?\n       .*node.* debug <host>:<port>\r?\n       .*node.* debug -p <pid>\r?\n$/
    at ChildProcess.<anonymous> (/home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-debug-usage.js:25:12)
    at ChildProcess.<anonymous> (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:376:15)
    at ChildProcess.emit (events.js:375:28)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-debug-usage.js
=== release test-debugger-pid ===
Path: parallel/test-debugger-pid
assert.js:118
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'internal/bootstrap/loaders.js:314'
- "Target process: 655555 doesn't exist."
    at ChildProcess.<anonymous> (/home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-debugger-pid.js:41:16)
    at ChildProcess.emit (events.js:375:28)
    at /home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-debugger-pid.js:18:16
    at Array.forEach (<anonymous>)
    at Socket.onData (/home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-debugger-pid.js:17:8)
    at Socket.emit (events.js:375:28)
    at addChunk (internal/streams/readable.js:290:12)
    at readableAddChunk (internal/streams/readable.js:261:11)
    at Socket.Readable.push (internal/streams/readable.js:204:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'internal/bootstrap/loaders.js:314',
  expected: "Target process: 655555 doesn't exist.",
  operator: 'strictEqual'
}
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/parallel/test-debugger-pid.js
=== release test-inspector-cli-address ===
Path: inspector-cli/test-inspector-cli-address
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Child exited, code 1 while waiting for />\s+$/; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: Error: Child exited, code 1 while waiting for />\s+$/; found: undefined
   STDERR: internal/bootstrap/loaders.js:314
    if (!mod) throw new TypeError(`Missing internal module '${id}'`);
              ^

  TypeError: Missing internal module 'timers/promises'
      at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
      at internal/inspector/_inspect.js:58:5
      at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
      at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
      at internal/main/inspect.js:21:3
      at processTicksAndRejections (internal/process/task_queues.js:77:11)

      at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
      at ChildProcess.emit (events.js:375:28)
      at maybeClose (internal/child_process.js:1055:16)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5),
  expected: null,
  operator: 'ifError'
}
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-address.js
=== release test-inspector-cli-auto-resume ===
Path: inspector-cli/test-inspector-cli-auto-resume
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-auto-resume.js
=== release test-inspector-cli-backtrace ===
Path: inspector-cli/test-inspector-cli-backtrace
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-backtrace.js
=== release test-inspector-cli-break ===
Path: inspector-cli/test-inspector-cli-break
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-break.js
=== release test-inspector-cli-clear-breakpoints ===
Path: inspector-cli/test-inspector-cli-clear-breakpoints
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-clear-breakpoints.js
=== release test-inspector-cli-custom-port ===
Path: inspector-cli/test-inspector-cli-custom-port
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-custom-port.js
=== release test-inspector-cli-exceptions ===
Path: inspector-cli/test-inspector-cli-exceptions
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-exceptions.js
=== release test-inspector-cli-exec ===
Path: inspector-cli/test-inspector-cli-exec
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-exec.js
=== release test-inspector-cli-exec-scope ===
Path: inspector-cli/test-inspector-cli-exec-scope
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-exec-scope.js
=== release test-inspector-cli-heap-profiler ===
Path: inspector-cli/test-inspector-cli-heap-profiler
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-heap-profiler.js
=== release test-inspector-cli-help ===
Path: inspector-cli/test-inspector-cli-help
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-help.js
=== release test-inspector-cli-invalid-args ===
Path: inspector-cli/test-inspector-cli-invalid-args
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

AssertionError [ERR_ASSERTION]: Prints usage info
    at /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-invalid-args.js:18:14 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 'internal/bootstrap/loaders.js:314\n' +
    "  if (!mod) throw new TypeError(`Missing internal module '${id}'`);\n" +
    '            ^\n' +
    '\n' +
    "TypeError: Missing internal module 'timers/promises'\n" +
    '    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)\n' +
    '    at internal/inspector/_inspect.js:58:5\n' +
    '    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)\n' +
    '    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)\n' +
    '    at internal/main/inspect.js:21:3\n' +
    '    at processTicksAndRejections (internal/process/task_queues.js:77:11)\n',
  expected: /^Usage:/,
  operator: 'match'
}
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-invalid-args.js
=== release test-inspector-cli-launch ===
Path: inspector-cli/test-inspector-cli-launch
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-launch.js
=== release test-inspector-cli-low-level ===
Path: inspector-cli/test-inspector-cli-low-level
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-low-level.js
=== release test-inspector-cli-pid ===
Path: inspector-cli/test-inspector-cli-pid
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Child exited, code 1 while waiting for />\s+$/; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: Error: Child exited, code 1 while waiting for />\s+$/; found: undefined
   STDERR: internal/bootstrap/loaders.js:314
    if (!mod) throw new TypeError(`Missing internal module '${id}'`);
              ^

  TypeError: Missing internal module 'timers/promises'
      at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
      at internal/inspector/_inspect.js:58:5
      at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
      at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
      at internal/main/inspect.js:21:3
      at processTicksAndRejections (internal/process/task_queues.js:77:11)

      at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
      at ChildProcess.emit (events.js:375:28)
      at maybeClose (internal/child_process.js:1055:16)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5),
  expected: null,
  operator: 'ifError'
}
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-pid.js
=== release test-inspector-cli-preserve-breaks ===
Path: inspector-cli/test-inspector-cli-preserve-breaks
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-preserve-breaks.js
=== release test-inspector-cli-profile ===
Path: inspector-cli/test-inspector-cli-profile
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-profile.js
=== release test-inspector-cli-random-port ===
Path: inspector-cli/test-inspector-cli-random-port
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-random-port.js
=== release test-inspector-cli-random-port-with-inspect-port ===
Path: inspector-cli/test-inspector-cli-random-port-with-inspect-port
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-random-port-with-inspect-port.js
=== release test-inspector-cli-run-after-quit-restart ===
Path: inspector-cli/test-inspector-cli-run-after-quit-restart
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-run-after-quit-restart.js
=== release test-inspector-cli-sb-before-load ===
Path: inspector-cli/test-inspector-cli-sb-before-load
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-sb-before-load.js
=== release test-inspector-cli-scripts ===
Path: inspector-cli/test-inspector-cli-scripts
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-scripts.js
=== release test-inspector-cli-use-strict ===
Path: inspector-cli/test-inspector-cli-use-strict
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-use-strict.js
=== release test-inspector-cli-watchers ===
Path: inspector-cli/test-inspector-cli-watchers
/home/rlau/sandbox/github/trees/v14.x-staging/test/common/index.js:634
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: Child exited, code 1 while waiting for /break (?:on start )?in/i; found: undefined
 STDERR: internal/bootstrap/loaders.js:314
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'timers/promises'
    at nativeModuleRequire (internal/bootstrap/loaders.js:314:19)
    at internal/inspector/_inspect.js:58:5
    at NativeModule.compileForInternalLoader (internal/bootstrap/loaders.js:286:7)
    at nativeModuleRequire (internal/bootstrap/loaders.js:315:14)
    at internal/main/inspect.js:21:3
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

    at ChildProcess.onChildClose (/home/rlau/sandbox/github/trees/v14.x-staging/test/common/inspector-cli.js:79:18)
    at ChildProcess.emit (events.js:375:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
Command: out/Release/node /home/rlau/sandbox/github/trees/v14.x-staging/test/inspector-cli/test-inspector-cli-watchers.js
[02:33|% 100|+ 3188|-  27]: Done

While setTimeout can be util.promisify()'ed in Node.js 14, setInterval currently cannot -- I think at least #37153 would be required and that is semver-minor.

@Trott
Copy link
Member Author

Trott commented Jul 19, 2021

While setTimeout can be util.promisify()'ed in Node.js 14, setInterval currently cannot -- I think at least #37153 would be required and that is semver-minor.

I guess our options are:

Did I miss anything? Which is the most desirable way to go with this?

@Trott
Copy link
Member Author

Trott commented Jul 19, 2021

Actually, I think this one can just be not landed. It's a lint-only change and a small one at that.
¯\(ツ)

@richardlau
Copy link
Member

While setTimeout can be util.promisify()'ed in Node.js 14, setInterval currently cannot -- I think at least #37153 would be required and that is semver-minor.

I guess our options are:

Did I miss anything? Which is the most desirable way to go with this?

The last one, but that would need to wait for a semver-minor release of 14.x (I'm currently preparing a patch release). FYI @targos (as you've volunteered for the next 14.x semver-minor).

@targos
Copy link
Member

targos commented Jul 19, 2021

The last one, but that would need to wait for a semver-minor release of 14.x

That one can't really land on v14.x. The timers/promises module isn't available there because it was considered semver-major: #33950 (the PR is marked backported-to-v14.x because the internal refactoring was backported).

aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: nodejs#38847
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau
Copy link
Member

Backport to v14.x PR: #39446

aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: nodejs#38847
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: nodejs#38847
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: #38847
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: #38847
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Jul 22, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: nodejs#38847
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants