Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove references to deleted freenode channels #39047

Merged
merged 1 commit into from
Jun 17, 2021
Merged

doc: remove references to deleted freenode channels #39047

merged 1 commit into from
Jun 17, 2021

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jun 15, 2021 •
edited
Loading

Refs nodejs/TSC#1031

cc @nodejs/tsc @nodejs/build

@github-actions github-actions bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jun 15, 2021
mcollina
mcollina approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mhdawson
mhdawson approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

I'd propose a fast track for this

@benjamingr benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@bnb
Copy link
Contributor

bnb commented Jun 16, 2021

If this lands, I’d assume nodejs/nodejs.org#3923 or some variant should also probably land too.

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/39047
✔  Done loading data for nodejs/node/pull/39047
----------------------------------- PR info ------------------------------------
Title      doc: remove references to deleted freenode channels (#39047)
Author     devsnek  (@devsnek)
Branch     devsnek:rip-freenode -> nodejs:master
Labels     doc, fast-track, meta
Commits    1
 - doc: remove references to deleted freenode channels
Committers 1
 - Gus Caplan 
PR-URL: https://github.com/nodejs/node/pull/39047
Reviewed-By: Robert Nagy 
Reviewed-By: Mary Marchini 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Michael Dawson 
Reviewed-By: Zijian Liu 
Reviewed-By: Khaidi Chu 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39047
Reviewed-By: Robert Nagy 
Reviewed-By: Mary Marchini 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Michael Dawson 
Reviewed-By: Zijian Liu 
Reviewed-By: Khaidi Chu 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 15 Jun 2021 20:38:28 GMT
   ✔  Approvals: 12
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684466041
   ✔  - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684480431
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684510273
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684531260
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684663596
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/39047#pullrequestreview-685131502
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39047#pullrequestreview-685141388
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-685361956
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-685544629
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/39047#pullrequestreview-685813419
   ✔  - Khaidi Chu (@XadillaX): https://github.com/nodejs/node/pull/39047#pullrequestreview-685829599
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39047#pullrequestreview-686087441
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/945925856

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 17, 2021
@devsnek
doc: remove references to deleted freenode channels
e3ba960 
PR-URL: #39047
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@devsnek devsnek merged commit e3ba960 into master Jun 17, 2021
@devsnek devsnek deleted the rip-freenode branch June 17, 2021 12:45
@devsnek
Copy link
Member Author

devsnek commented Jun 17, 2021

landed in e3ba960

joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jun 17, 2021
@devsnek @joyeecheung
doc: remove references to deleted freenode channels
b027ed3 
PR-URL: nodejs#39047
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@devsnek @danielleadams
doc: remove references to deleted freenode channels
dce256b 
PR-URL: #39047
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
@richardlau richardlau mentioned this pull request Jun 23, 2021
Closed
@bnb bnb mentioned this pull request Jul 1, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@devsnek @richardlau
doc: remove references to deleted freenode channels
59b2476 
PR-URL: #39047
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@devsnek @richardlau
doc: remove references to deleted freenode channels
04032fa 
PR-URL: #39047
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@devsnek @foxxyz
doc: remove references to deleted freenode channels
81c7ed2 
PR-URL: nodejs#39047
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@mmarchini mmarchini mmarchini approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@tniessen tniessen tniessen approved these changes

@mcollina mcollina mcollina approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@joesepi joesepi joesepi approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@ronag ronag ronag approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.