lib: expose DOMException as global

[XadillaX]

Fixes: #39098

[aduh95]

Can you add an entry in

node/lib/.eslintrc.yaml

Lines 38 to 40 in 7919ced

	- name: Buffer
	message: "Use `const { Buffer } = require('buffer');` instead of the global."
	- name: Event

to forbid the use of DOMException global from core.

[XadillaX]

Can you add an entry in

node/lib/.eslintrc.yaml

Lines 38 to 40 in 7919ced

	- name: Buffer
	message: "Use `const { Buffer } = require('buffer');` instead of the global."
	- name: Event

to forbid the use of DOMException global from core.

Done.

[targos]

Maybe Web IDL instead of WHATWG ?

[XadillaX]

https://dom.spec.whatwg.org/

hmmm, isn't it WHATWG DOMException?

[targos]

DOMException is defined here: https://heycam.github.io/webidl/#idl-DOMException (the DOM spec links to that too)
WHATWG is the group that writes the standards and it feels weird to me to use that name as the reference. Kind of like if we said "The TC39 SyntaxError".

[XadillaX]

What confused me is that likely URL has an IDL way:

[Exposed=(Window,Worker),
 LegacyWindowAlias=webkitURL]
interface URL {
  constructor(USVString url, optional USVString base);

  stringifier attribute USVString href;
  readonly attribute USVString origin;
           attribute USVString protocol;
           attribute USVString username;
           attribute USVString password;
           attribute USVString host;
           attribute USVString hostname;
           attribute USVString port;
           attribute USVString pathname;
           attribute USVString search;
  [SameObject] readonly attribute URLSearchParams searchParams;
           attribute USVString hash;

  USVString toJSON();
};

[Exposed=(Window,Worker)]
interface URLSearchParams {
  constructor(optional (sequence<sequence<USVString>> or record<USVString, USVString> or USVString) init = "");

  undefined append(USVString name, USVString value);
  undefined delete(USVString name);
  USVString? get(USVString name);
  sequence<USVString> getAll(USVString name);
  boolean has(USVString name);
  undefined set(USVString name, USVString value);

  undefined sort();

  iterable<USVString, USVString>;
  stringifier;
};

So when should we use Web IDL and when should we use WHATWG?

[targos]

I think we should stop using WHATWG completely and always use Web instead. I know that right now the situation is mixed. In the documentation we have "WHATWG URL" and "WHATWG Encoding", but on the other hand we have "Web Streams" and "Web Crypto"...

[XadillaX]

You mean use:

Web URL / Web TextEncoder?

[jasnell]

I would just remove the The WHATWG DOMException class. sentence entirely.

[RaisinTen]

@targos Shouldn't this be semver-minor as it doesn't break any existing code?

[aduh95]

@targos Shouldn't this be semver-minor as it doesn't break any existing code?

Adding new globals is considered semver-major, see #20306 for context.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39215/ 💚

[jasnell]

Landed in e4b1fb5

[jimmywarting]

I think It's always so confusing when PR are closed and not merged... and somehow magically merged from somewhere else 👀

[kanongil]

I find it strange that this is merged without considering what it does to AbortError.

The WHATWG AbortController APIs are designed to work with new DOMException(message, 'AbortError'). Now node supports this, but internal APIs still throw a custom AbortError extended from Error!