Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: cleanup async handling #39329

Closed
wants to merge 3 commits into from
Closed

stream: cleanup async handling #39329

wants to merge 3 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 9, 2021 •
edited
Loading

Cleanup async stream method handling. Removes duplicate code and unifies behavior.

@ronag
Copy link
Member Author

ronag commented Jul 9, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 9, 2021
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. stream Issues and PRs related to the stream subsystem. and removed needs-ci PRs that need a full CI run. labels Jul 9, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38922/

@ronag ronag force-pushed the stream-async branch 3 times, most recently from 495aa7a to 71a01e0 Compare July 9, 2021 18:36
mcollina
mcollina approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 9, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38926/

@mcollina mcollina added dont-land-on-v12.x baking-for-lts PRs that need to wait before landing in a LTS release. labels Jul 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38939/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38945/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38959/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38964/

@ronag
stream: cleanup async handling
f115b89 
Cleanup async stream method handling.
@ronag
fixup
873314c
@ronag
fixup
a722ca3
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38965/

ronag added a commit that referenced this pull request Jul 11, 2021
@ronag
stream: cleanup async handling
f2f6872 
Cleanup async stream method handling.

PR-URL: #39329
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ronag
Copy link
Member Author

ronag commented Jul 11, 2021

Landed in f2f6872

@ronag ronag closed this Jul 11, 2021
targos pushed a commit that referenced this pull request Jul 13, 2021
@ronag @targos
stream: cleanup async handling
cb32f69 
Cleanup async stream method handling.

PR-URL: #39329
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 13, 2021
Merged
@tchetwin tchetwin mentioned this pull request Jul 26, 2021
Closed
@ronag ronag mentioned this pull request Jul 27, 2021
Merged
@Flarna
Copy link
Member

Flarna commented Jul 27, 2021

@ronag Should we add a dont-land-on-v14.x label here because of #39535

@targos targos removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @Flarna @mcollina @jasnell @targos