test: address flaky test-http-client-timeout-event #3968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: nodejs#2555
|
Stress test to show that this actually fixes the problem: https://ci.nodejs.org/job/node-stress-single-test/nodes=pi1-raspbian-wheezy/27/console For good measure, stress test without this change to show that the problem still exists: https://ci.nodejs.org/job/node-stress-single-test/24/nodes=pi1-raspbian-wheezy/console |
mscdex
added
http
|
This LGTM. |
|
LGTM |
1 similar comment
|
LGTM |
Trott
added a commit
that referenced
this pull request
Nov 23, 2015
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: #2555 PR-URL: #3968 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott
added a commit
that referenced
this pull request
Dec 1, 2015
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: #2555 PR-URL: #3968 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott
added a commit
that referenced
this pull request
Dec 4, 2015
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: #2555 PR-URL: #3968 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott
added a commit
that referenced
this pull request
Dec 5, 2015
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: #2555 PR-URL: #3968 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
This was referenced Dec 8, 2015
Closed
Trott
added a commit
that referenced
this pull request
Dec 17, 2015
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: #2555 PR-URL: #3968 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott
added a commit
that referenced
this pull request
Dec 23, 2015
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: #2555 PR-URL: #3968 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common.platformTimeout() to make test more reliable on Raspberry Pi.
Fixes: #2555