Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Replace sane with reasonable #3980

Closed
wants to merge 1 commit into from

Conversation

lewiscowper
Copy link
Contributor

I noticed this slip when reading about modules, and thought I'd pop a PR in.

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Nov 23, 2015
@ChALkeR
Copy link
Member

ChALkeR commented Nov 23, 2015

The correct prefix for the commit title would be «doc: », not «docs: ».

@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Nov 23, 2015
@evanlucas
Copy link
Contributor

LGTM with what @ChALkeR said

@targos
Copy link
Member

targos commented Nov 23, 2015

LGTM

Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
@lewiscowper
Copy link
Contributor Author

Pushed new prefix now.

@lewiscowper lewiscowper changed the title docs: Replace sane with reasonable doc: Replace sane with reasonable Nov 23, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Nov 23, 2015

LGTM

targos pushed a commit to targos/node that referenced this pull request Nov 23, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: nodejs#3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos
Copy link
Member

targos commented Nov 23, 2015

landed in 3becac2

@targos targos closed this Nov 23, 2015
MylesBorins pushed a commit that referenced this pull request Dec 1, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Dec 4, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Dec 5, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants