-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Replace sane with reasonable #3980
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct prefix for the commit title would be «doc: », not «docs: ». |
LGTM with what @ChALkeR said |
LGTM |
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across.
lewiscowper
force-pushed
the
language-tweak
branch
from
November 23, 2015 09:20
b6682f0
to
9558d59
Compare
Pushed new prefix now. |
lewiscowper
changed the title
docs: Replace sane with reasonable
doc: Replace sane with reasonable
Nov 23, 2015
LGTM |
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 23, 2015
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: nodejs#3980 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
landed in 3becac2 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 1, 2015
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: #3980 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: #3980 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Dec 5, 2015
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: #3980 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 8, 2015
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: #3980 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: #3980 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this slip when reading about modules, and thought I'd pop a PR in.