Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,crypto: remove AllocatedBuffer from crypto_cipher.cc #40400

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen [email protected]

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Oct 10, 2021
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen force-pushed the src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc branch from 9841890 to 869adb8 Compare October 11, 2021 13:23
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 13, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@github-actions
Copy link
Contributor

Landed in aef8abb...e1d598c

@github-actions github-actions bot closed this Oct 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2021
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40400
Reviewed-By: Anna Henningsen <[email protected]>
@RaisinTen RaisinTen deleted the src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc branch October 20, 2021 15:08
targos pushed a commit that referenced this pull request Oct 23, 2021
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40400
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40400
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants