Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,build,tools: fix openssl-is-fips for ninja builds #40518

Closed
wants to merge 3 commits into from
Closed

deps,build,tools: fix openssl-is-fips for ninja builds #40518

wants to merge 3 commits into from

Commits on Oct 19, 2021

  1. deps,build,tools: fix openssl-is-fips for ninja builds 

    Currently using the --openssl-is-fips configuration option in
combination with --ninja is broken.

This commit fixes two issues, one being an issue with the linker/version
script path variable. The second is that the locations of built
artifacts that differ for ninja and make.

ninja:
$ ./configure --openssl-is-fips --ninja
$ ninja -C out/Release
$ ./node --enable-fips -p 'crypto.getFips()'
1

make:
$ ./configure --openssl-is-fips
$ make -j8
$ ./node --enable-fips -p 'crypto.getFips()'
1

Refs: nodejs#40509
    @danbev
    danbev committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    757e147 View commit details
    Browse the repository at this point in the history

  2. deps: regenerate OpenSSL arch files 

    Refs: nodejs#40509
    @danbev
    danbev committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    7cf53e5 View commit details
    Browse the repository at this point in the history

  3. deps: attempt to suppress macro-redefined warning

    @danbev
    danbev committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    cf7801d View commit details
    Browse the repository at this point in the history