Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: destroying stream without error is abort #40806

Closed
wants to merge 1 commit into from
Closed

stream: destroying stream without error is abort #40806

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 13, 2021

If an autoDestroy stream is destroyed by user without
an error we automatically convert it to an AbortError in
order to avoid a weird state.

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Nov 13, 2021
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2021
@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 13, 2021
@ronag ronag force-pushed the auto-abort branch 2 times, most recently from 509b3d9 to a3b44a4 Compare November 13, 2021 16:47
@ronag ronag marked this pull request as ready for review November 13, 2021 16:47
@ronag ronag force-pushed the auto-abort branch 3 times, most recently from 873d061 to a35103f Compare November 13, 2021 16:56
@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 13, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40874/

@ronag ronag requested a review from mcollina November 13, 2021 17:16
@lpinca
Copy link
Member

lpinca commented Nov 13, 2021

This will not affect me directly but I think it will cause unnecessary breakage.

@ronag
Copy link
Member Author

ronag commented Nov 13, 2021

I think current implementation can cause a lot of confusion and weird edge cases.

@github-actions github-actions bot mentioned this pull request Nov 14, 2021
Open
41 tasks
@ronag ronag marked this pull request as draft November 14, 2021 14:04
@ronag
stream: destroying stream without error is abort
eaddb03 
If an autoDestroy stream is destroyed by user without
an error we automatically convert it to an AbortError in
order to avoid a weird state.
@ronag
Copy link
Member Author

ronag commented Nov 14, 2021

This won't work unfortunately. Way to breaking.

@ronag ronag closed this Nov 14, 2021
This was referenced Nov 15, 2021
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@jasnell jasnell jasnell approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @lpinca @jasnell @VoltrexKeyva