tools: enable JSDoc check-alignment lint rule #41109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
commit-queue-rebase
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Dec 7, 2021
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
targos
reviewed
Dec 7, 2021
Trott
force-pushed
the
jsdoc-check-alignment
branch
from
d364d56
to
7347e2c
Compare
This comment has been minimized.
This comment has been minimized.
|
@targos Yes, I like your suggestions better than the auto-fixed changes. Adopted. Thanks! |
targos
approved these changes
Dec 7, 2021
BridgeAR
approved these changes
Dec 7, 2021
lpinca
approved these changes
Dec 7, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 8, 2021
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41109 ✔ Done loading data for nodejs/node/pull/41109 ----------------------------------- PR info ------------------------------------ Title tools: enable JSDoc check-alignment lint rule (#41109) Author Rich Trott (@Trott) Branch Trott:jsdoc-check-alignment -> nodejs:master Labels tools, needs-ci, commit-queue-rebase Commits 2 - doc,lib,tools: align multiline comments - tools: enable JSDoc check-alignment lint rule Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41109 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41109 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 07 Dec 2021 14:38:30 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825370225 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825595191 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825647060 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41109#pullrequestreview-825760708 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-12-07T23:31:07Z: https://ci.nodejs.org/job/node-test-pull-request/41413/ - Querying data for job/node-test-pull-request/41413/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41109 From https://github.com/nodejs/node * branch refs/pull/41109/merge -> FETCH_HEAD ✔ Fetched commits as 3697587c31c7..7347e2cfd83b -------------------------------------------------------------------------------- [master a458871855] doc,lib,tools: align multiline comments Author: Rich Trott Date: Tue Dec 7 06:35:08 2021 -0800 4 files changed, 7 insertions(+), 7 deletions(-) [master 140daca3a6] tools: enable JSDoc check-alignment lint rule Author: Rich Trott Date: Tue Dec 7 06:35:45 2021 -0800 1 file changed, 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)
Temporary files removed.
|
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: nodejs#41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
force-pushed
the
jsdoc-check-alignment
branch
from
7347e2c
to
ecf4114
Compare
|
Landed in 3697587...ecf4114 |
This was referenced Dec 10, 2021
This was referenced Dec 12, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
46 tasks
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
24 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: nodejs#41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41109 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects more than just JSDoc comments, but I'm OK with that.