child_process: queue pending messages #41221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
ErickWendel
force-pushed
the
erickwendel/queue-pending-messages-fork-process
branch
2 times, most recently
from
3b94fc1
to
eb8c12a
Compare
aduh95
reviewed
Dec 17, 2021
aduh95
reviewed
Dec 17, 2021
ErickWendel
force-pushed
the
erickwendel/queue-pending-messages-fork-process
branch
3 times, most recently
from
da5b44c
to
eef3572
Compare
ErickWendel
deleted the
erickwendel/queue-pending-messages-fork-process
branch
ErickWendel
restored the
erickwendel/queue-pending-messages-fork-process
branch
felipe-ssilva
approved these changes
Dec 17, 2021
joaopcm
approved these changes
Dec 17, 2021
edsadr
approved these changes
Dec 17, 2021
edsadr
requested changes
Dec 17, 2021
IcaroBichir
approved these changes
Dec 17, 2021
aduh95
reviewed
Dec 17, 2021
aduh95
reviewed
Dec 17, 2021
aduh95
reviewed
Dec 17, 2021
ErickWendel
force-pushed
the
erickwendel/queue-pending-messages-fork-process
branch
from
eef3572
to
49abb89
Compare
|
Could you add a test please? Let me know if you need help writing one. |
There're tests for it before. The problem is that on ESM the behavior is different. As the coverage didn't change I didn't create a test for it. Do you think it's really necessary? |
|
Yes, we could simply copy the test we have and port it to ESM. It is necessary, otherwise another future change may break it again for ESM and we wouldn't be able to tell. |
ErickWendel
force-pushed
the
erickwendel/queue-pending-messages-fork-process
branch
from
49abb89
to
0f48517
Compare
Got it! Let me know if this is what you suggested. |
ErickWendel
force-pushed
the
erickwendel/queue-pending-messages-fork-process
branch
3 times, most recently
from
0168b1b
to
100b785
Compare
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
It fixes the problem of the child process not receiving messages. Fixes: nodejs#41134 PR-URL: nodejs#41221 Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
3 tasks
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
It fixes the problem of the child process not receiving messages. Fixes: #41134 PR-URL: #41221 Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
mateus-f-torres
added a commit
to mateus-f-torres/barefoot
that referenced
this pull request
Feb 7, 2022
Needed to resolve issue with Jest process (nodejs/node#41221)
3 tasks
mateus-f-torres
added a commit
to mateus-f-torres/barefoot
that referenced
this pull request
Feb 9, 2022
Needed to resolve issue with Jest process (nodejs/node#41221)
1 task
mateus-f-torres
added a commit
to mateus-f-torres/barefoot
that referenced
this pull request
Mar 24, 2022
Needed to resolve issue with Jest process (nodejs/node#41221)
mateus-f-torres
added a commit
to mateus-f-torres/barefoot
that referenced
this pull request
Mar 24, 2022
Needed to resolve issue with Jest process (nodejs/node#41221)
1 task
|
Will this be fixed in 14 LTS ? |
|
v14.x is in maintenance mode, meaning that no change land there unless someone opens a PR to backport it. See https://github.com/nodejs/node/blob/master/doc/contributing/backporting-to-release-lines.md for more info. |
|
@aduh95 @sublimator just added a PR for backing porting this feature for 14.x. 🤩 |
aduh95
added
backport-open-v14.x
and removed
commit-queue-failed
It will ❤️ |
juanarbol
pushed a commit
that referenced
this pull request
May 1, 2022
It fixes the problem of the child process not receiving messages. Fixes: #41134 PR-URL: #41221 Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Backport-PR-URL: #42840
Merged
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Jun 13, 2022
This version includes a fix so we can/would run jest with Yarn PnP: nodejs/node#41221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the problem for child process not receiving messages when forking a process and immediately sending messages on ESM by queuing messages until the process is ready.
Fixes: #41134
Refs: #37782, #39140, #39140, #34785, and help/issues/1383