Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: revise argument processing #41280

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 22, 2021

execFile() and fork() have complicated argument processing. Clarify code
and avoid using arguments.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2021
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Dec 22, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2021
@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions that make this change semver-major, but also more "correct", so maybe it's worth it?

lib/child_process.js Show resolved Hide resolved
lib/child_process.js Outdated Show resolved Hide resolved
lib/child_process.js Show resolved Hide resolved
lib/child_process.js Show resolved Hide resolved
execFile() and fork() have complicated argument processing. Clarify code
and avoid using `arguments`.
@nodejs-github-bot

This comment has been minimized.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2021
@nodejs-github-bot nodejs-github-bot merged commit 4069e7e into nodejs:master Dec 24, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 4069e7e

targos pushed a commit that referenced this pull request Jan 14, 2022
execFile() and fork() have complicated argument processing. Clarify code
and avoid using `arguments`.

PR-URL: #41280
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
execFile() and fork() have complicated argument processing. Clarify code
and avoid using `arguments`.

PR-URL: #41280
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
execFile() and fork() have complicated argument processing. Clarify code
and avoid using `arguments`.

PR-URL: nodejs#41280
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
execFile() and fork() have complicated argument processing. Clarify code
and avoid using `arguments`.

PR-URL: #41280
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants