tools: enable jsdoc/check-param-names lint rule #41311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
aduh95
approved these changes
Dec 25, 2021
aduh95
added
author ready
Trott
added
the
commit-queue-rebase
lpinca
approved these changes
Dec 28, 2021
Trott
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/41311 ✔ Done loading data for nodejs/node/pull/41311 ----------------------------------- PR info ------------------------------------ Title tools: enable jsdoc/check-param-names lint rule (#41311) Author Rich Trott (@Trott) Branch Trott:jsdoc-check-param-names -> nodejs:master Labels tools, author ready, commit-queue-rebase Commits 2 - events: clarify JSDoc entries - tools: enable jsdoc/check-param-names lint rule Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41311 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41311 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 24 Dec 2021 15:30:28 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41311#pullrequestreview-839997812 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41311#pullrequestreview-841065507 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1631805998 |
nodejs-github-bot
added
the
commit-queue-failed
Trott
removed
the
commit-queue-failed
Split the JSDoc entries into separate blocks. This is in preparation for enabling jsdoc/check-param-names lint rule. PR-URL: nodejs#41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
force-pushed
the
jsdoc-check-param-names
branch
from
c618d91
to
f81c627
Compare
|
Landed in 5ed7066...f81c627 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Split the JSDoc entries into separate blocks. This is in preparation for enabling jsdoc/check-param-names lint rule. PR-URL: #41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Split the JSDoc entries into separate blocks. This is in preparation for enabling jsdoc/check-param-names lint rule. PR-URL: nodejs#41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Split the JSDoc entries into separate blocks. This is in preparation for enabling jsdoc/check-param-names lint rule. PR-URL: #41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41311 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.