Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: replace for loop with map() #41451

Merged
merged 1 commit into from
Jan 13, 2022
Merged

tools: replace for loop with map() #41451

merged 1 commit into from
Jan 13, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 9, 2022

Refs: #41406 (comment)
Co-authored-by: Tobias Nießen [email protected]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 9, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2022
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2022
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 13, 2022

Landed in 500241d

@Trott Trott merged commit 500241d into nodejs:master Jan 13, 2022
@Trott Trott deleted the map-it branch January 13, 2022 06:11
targos pushed a commit that referenced this pull request Jan 14, 2022
Refs: #41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: #41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Refs: nodejs#41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: nodejs#41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Refs: #41406 (comment)
Co-authored-by: Tobias Nießen <[email protected]>

PR-URL: #41451
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants