Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x] deps: V8: cherry-pick d8dc66f #41566

Closed
wants to merge 5 commits into from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Jan 17, 2022

Fix riscv64 segment fault
origin commit :

[riscv64][sparkplug] Fix sparkplug verify framesize failed

Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009
Auto-Submit: Yahan Lu <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Commit-Queue: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#76277}

Refs: v8/v8@d8dc66f

[riscv64] Use s1 to save code_obj

The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj.

Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886
Reviewed-by: Ji Qiu <[email protected]>
Commit-Queue: Ji Qiu <[email protected]>
Commit-Queue: Yahan Lu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#76294}

Refs: v8/v8@3cab84c

[riscv64] Link should greater and equal zero

Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673
Commit-Queue: Yahan Lu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#76784}

Refs: v8/v8@471f862

[riscv64] Add block before LoadAddress

fix node.js DCHECK failed
issue: https://github.com/riscv-collab/v8/issues/514

Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979
Reviewed-by: ji qiu <[email protected]>
Commit-Queue: ji qiu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#77750}

Refs: v8/v8@77599ff

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@luyahan luyahan changed the base branch from master to v16.x-staging January 17, 2022 08:00
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jan 17, 2022
@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022

Reland #41564 @gengjiawen @targos

@targos
Copy link
Member

targos commented Jan 17, 2022

@luyahan do you target v16.x-staging because the fixes are already in v17.x ?

@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022

@luyahan do you target v16.x-staging because the fixes are already in v17.x ?

Yes.

@luyahan luyahan changed the title deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff deps: V8: cherry-pick Jan 17, 2022
@luyahan luyahan changed the title deps: V8: cherry-pick deps: V8: cherry-pick d8dc66f Jan 17, 2022
Original commit message:

    [riscv64][sparkplug] Fix sparkplug verify framesize failed

    Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009
    Auto-Submit: Yahan Lu <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76277}

Refs: v8/v8@d8dc66f9
Original commit message:

    [riscv64] Use s1 to save code_obj

    The caller saved a4 may be clobbered by the callee function.
    So we substitute it with the callee saved s1 to save code_obj.

    Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76294}

Refs:  v8/v8@3cab84c2472
Original commit message:

    [riscv64] Link should greater and equal zero

    Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#76784}

Refs: v8/v8@471f862954f3
Original commit message:

    [sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG

    There is still a place to simplify.

    Bug: v8:11420, v8:11421
    Change-Id: I774139c52d911323f162350532a493e70f518643
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885
    Auto-Submit: Yahan Lu <[email protected]>
    Commit-Queue: Leszek Swirski <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76296}

Refs: v8/v8@e74d6918fb9
Original commit message:

    [riscv64] Add block before LoadAddress

    fix node.js DCHECK failed
    issue: riscv-collab/v8#514

    Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979
    Reviewed-by: ji qiu <[email protected]>
    Commit-Queue: ji qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#77750}

Refs: v8/v8@77599ffe0a74
@luyahan luyahan changed the title deps: V8: cherry-pick d8dc66f deps: V8: cherry-pick d8dc66f Jan 17, 2022
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2022

@nodejs-github-bot
Copy link
Collaborator

@luyahan
Copy link
Contributor Author

luyahan commented Jan 18, 2022

How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console?
I can't understand this output.

@targos targos changed the title deps: V8: cherry-pick d8dc66f [v16.x] deps: V8: cherry-pick d8dc66f Jan 18, 2022
@targos targos added the v16.x label Jan 18, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2022

@XieJiSS
Copy link

XieJiSS commented Jan 19, 2022

How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console? I can't understand this output.

@luyahan Seems like a test case is failing: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win10-COMPILED_BY-vs2019/13158/console

That's strange, because this PR does not mess up with those Windows stuff.

@richardlau
Copy link
Member

How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console? I can't understand this output.

@luyahan Seems like a test case is failing: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win10-COMPILED_BY-vs2019/13158/console

You can ignore that one as it's a known flake #40728. The last CI (https://ci.nodejs.org/job/node-test-pull-request/41993/) passed.

@danielleadams
Copy link
Contributor

@luyahan @targos @richardlau what is the status of this? Does this need to be backported to include the base branch/PR metadata, or can we pull this into the next 16.x as is?

@targos
Copy link
Member

targos commented Jan 29, 2022

@danielleadams the changes only apply to v16.x, so we should directly pull this into the next release.

danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Original commit message:

    [riscv64][sparkplug] Fix sparkplug verify framesize failed

    Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009
    Auto-Submit: Yahan Lu <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76277}

Refs: v8/v8@d8dc66f9

PR-URL: #41566
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Original commit message:

    [riscv64] Use s1 to save code_obj

    The caller saved a4 may be clobbered by the callee function.
    So we substitute it with the callee saved s1 to save code_obj.

    Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76294}

Refs:  v8/v8@3cab84c2472

PR-URL: #41566
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Original commit message:

    [riscv64] Link should greater and equal zero

    Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#76784}

Refs: v8/v8@471f862954f3

PR-URL: #41566
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Original commit message:

    [sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG

    There is still a place to simplify.

    Bug: v8:11420, v8:11421
    Change-Id: I774139c52d911323f162350532a493e70f518643
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885
    Auto-Submit: Yahan Lu <[email protected]>
    Commit-Queue: Leszek Swirski <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76296}

Refs: v8/v8@e74d6918fb9

PR-URL: #41566
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Original commit message:

    [riscv64] Add block before LoadAddress

    fix node.js DCHECK failed
    issue: riscv-collab/v8#514

    Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979
    Reviewed-by: ji qiu <[email protected]>
    Commit-Queue: ji qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#77750}

Refs: v8/v8@77599ffe0a74

PR-URL: #41566
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams
Copy link
Contributor

Landed in 9e68c00...036650e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants