lib: refactor source map stack trace prepare #41698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesteery
reviewed
Jan 25, 2022
Mesteery
reviewed
Jan 25, 2022
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping.
VoltrexKeyva
force-pushed
the
refactor-srcmps-prep-stack-trace
branch
from
3b1c9e9
to
4d20097
Compare
Mesteery
approved these changes
Jan 25, 2022
benjamingr
approved these changes
Jan 26, 2022
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This was referenced Jan 27, 2022
Ayase-252
added
the
author ready
jasnell
approved these changes
Jan 28, 2022
22 tasks
Mesteery
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 85eca3d |
This was referenced Jan 30, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping. PR-URL: #41698 Reviewed-By: Mestery <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping. PR-URL: #41698 Reviewed-By: Mestery <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping. PR-URL: #41698 Reviewed-By: Mestery <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping. PR-URL: #41698 Reviewed-By: Mestery <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Make use of the logical OR operator (
||) for betterreadability.
• Remove unnecessary conditional and wrapping.