Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use class fields in classes that revert to symbol properties due to missing snapshot support #42361

Closed
wants to merge 3 commits into from
Closed

lib: use class fields in classes that revert to symbol properties due to missing snapshot support #42361

wants to merge 3 commits into from

Commits on Mar 16, 2022

  1. lib: update class fields TODO in abort_controller.js 

    https://bugs.chromium.org/p/v8/issues/detail?id=10704 is already
fixed, but since AbortController currently throws ERR_INVALID_THIS
we'll revert to class fields in a subsequent patch. For now just
update the comments.
    @joyeecheung
    joyeecheung committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    c8c6f0c View commit details
    Browse the repository at this point in the history

  2. lib: use class fields in Event and EventTarget 

    https://bugs.chromium.org/p/v8/issues/detail?id=10704 is already
fixed, so switch back to class fields instead of using symbol
properties.
    @joyeecheung
    joyeecheung committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    3e7e7ed View commit details
    Browse the repository at this point in the history

  3. lib: use class fields in observe.js 

    https://bugs.chromium.org/p/v8/issues/detail?id=10704 is already
fixed, so switch back to class fields instead of using
symbol properties.
    @joyeecheung
    joyeecheung committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    ccbb05f View commit details
    Browse the repository at this point in the history