benchmark: fix misc/startup failure #42442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
benjamingr
approved these changes
Mar 23, 2022
|
I would hold off on landing this because whether or not we are keeping |
This was referenced Mar 24, 2022
jasnell
approved these changes
Mar 25, 2022
This was referenced Mar 26, 2022
This was referenced Apr 2, 2022
|
Yea, I think it's probably fine to merge. Sorry for the hold up. |
aduh95
reviewed
Apr 12, 2022
| for (const key of canBeRequired) { | ||
| for (let key of canBeRequired) { | ||
| if (modulesNeedingPrefix.includes(key)) | ||
| key = `node:${key}`; | ||
| require(key); |
There was a problem hiding this comment.
Any reason not to use the prefix for all modules?
Suggested change
| require(key); | |
| require(`node:${key}`); |
|
Closing because #42746 has landed, and fixes the issue. Please re-open if I'm mistaken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #42437
It's not the ideal fix as it's duplicating a list/Set that already exists in the internals but 🤷♂️