Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: harden options typecheck in reading methods #42772

Closed
wants to merge 3 commits into from
Closed

fs: harden options typecheck in reading methods #42772

wants to merge 3 commits into from
+53 −18

Commits on Sep 9, 2022

  1. fs: harden filehandle.read(params) typecheck 

    Make sure that first argument is a nullable object

Co-authored-by: Antoine du Hamel <[email protected]>
    @LiviaMedeiros @aduh95
    LiviaMedeiros and aduh95 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    c81c873 View commit details
    Browse the repository at this point in the history

  2. fs: harden fs.read(params, callback) typecheck

    @LiviaMedeiros
    LiviaMedeiros committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    fc34407 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. fs: harden fs.readSync(buffer, options) typecheck 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @LiviaMedeiros @aduh95
    LiviaMedeiros and aduh95 committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    f56c683 View commit details
    Browse the repository at this point in the history