Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use node: prefix in example #42794

Merged
merged 1 commit into from
Apr 20, 2022
Merged

src: use node: prefix in example #42794

merged 1 commit into from
Apr 20, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 20, 2022

Refs: #42752

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 20, 2022 •
edited by aduh95
Loading

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 20, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 20, 2022
ShogunPanda
ShogunPanda approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 20, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@Lovelouis

This comment was marked as spam.

Sign in to view
@Trott

This comment was marked as resolved.

Sign in to view
@aduh95 aduh95 merged commit 09c329d into nodejs:master Apr 20, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 20, 2022

Landed in 09c329d

@aduh95 aduh95 deleted the node-prefix-example branch April 20, 2022 14:00
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@aduh95 @xtx1130
src: use node: prefix in example
a4dbef4 
Refs: nodejs#42752

PR-URL: nodejs#42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2022
@aduh95 @targos
src: use node: prefix in example
b7e9dd0 
Refs: #42752

PR-URL: #42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@aduh95 @juanarbol
src: use node: prefix in example
f41ea76 
Refs: #42752

PR-URL: #42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@aduh95 @danielleadams
src: use node: prefix in example
0646f94 
Refs: #42752

PR-URL: #42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95 @targos
src: use node: prefix in example
8f098ab 
Refs: #42752

PR-URL: #42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
src: use node: prefix in example
e769a0f 
Refs: #42752

PR-URL: #42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
src: use node: prefix in example
ce88009 
Refs: nodejs/node#42752

PR-URL: nodejs/node#42794
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@Trott Trott Trott approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @Lovelouis @Trott @ShogunPanda @RafaelGSS @Mesteery