Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: adjust position validation in reading methods #42835

Merged
merged 8 commits into from
Sep 29, 2023
Merged

fs: adjust position validation in reading methods #42835

merged 8 commits into from
Sep 29, 2023

Commits on Sep 15, 2023

  1. fs: adjust position validation in reading methods 

    This prohibits invalid values (< -1 and non-integers) and
allows `filehandle.read()` to handle position up to `2n ** 63n - 1n`
    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0b4ee39 View commit details
    Browse the repository at this point in the history

  2. squash: fix validation when position + length exceeds int64 limit

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0c2bea2 View commit details
    Browse the repository at this point in the history

  3. squash: add tests

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    c911c77 View commit details
    Browse the repository at this point in the history

  4. squash: resolve todo

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    022d17c View commit details
    Browse the repository at this point in the history

  5. squash: add test for Promises API

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    39007fb View commit details
    Browse the repository at this point in the history

  6. squash: add changes to docs

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    204fb4f View commit details
    Browse the repository at this point in the history

  7. squash: make linter happy

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    00f9189 View commit details
    Browse the repository at this point in the history

  8. squash: fix typo

    @LiviaMedeiros
    LiviaMedeiros committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    dc7a21e View commit details
    Browse the repository at this point in the history