Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: fix wasm_web_api external reference registration #42903

Merged
merged 1 commit into from
May 2, 2022
Merged

bootstrap: fix wasm_web_api external reference registration #42903

merged 1 commit into from
May 2, 2022

Conversation

joyeecheung
Copy link
Member

The external references were not actually registered.

@joyeecheung
bootstrap: fix wasm_web_api external reference registration
4d68b92 
The external references were not actually registered.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 29, 2022
tniessen
tniessen approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43783/

This was referenced Apr 30, 2022
Open
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit acffd3d into nodejs:master May 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in acffd3d

This was referenced May 3, 2022
Open
Open
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@joyeecheung @RafaelGSS
bootstrap: fix wasm_web_api external reference registration
9ee7d9e 
The external references were not actually registered.

PR-URL: #42903
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joyeecheung @nodejs-github-bot @addaleax @tniessen @aduh95 @VoltrexKeyva @targos @juanarbol