v18.3.0 proposal #43266

bengl · 2022-05-31T17:42:51Z

2022-05-31, Version 18.3.0 (Current), @bengl

Notable Changes

[dc3b91f351] - deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262
[d6cf409d78] - (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
[9539cfa358] - (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
[41fdc2617d] - deps: upgrade npm to 8.11.0 (npm team) #43210
[0000654e47] - deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
[b3c8e609fd] - (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
[3e89b7336d] - (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
[9539cfa358] - (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
[8f5b4570e5] - (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
[5eff7b4a6a] - (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) #42740
- This means 32-bit Windows binaries are back with this release.

Commits

[aefc9dda9a] - benchmark: add node-error benchmark (RafaelGSS) #43077
[85d81a764f] - bootstrap: include code cache in the embedded snapshot (Joyee Cheung) #43023
[5eff7b4a6a] - (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) #42740
[d6634707c5] - (SEMVER-MINOR) build: run V8 tests with detected Python version (Richard Lau) #42740
[b8b5e6df67] - (SEMVER-MINOR) build: reset embedder string to "-node.0" (Michaël Zasso) #42740
[285ef30877] - console: fix console.dir crash on a revoked proxy (Daeyeon Jeong) #43100
[920d8c5300] - crypto: align webcrypto RSA key import/export with other implementations (Filip Skokan) #42816
[c76caadf2e] - debugger: throw a more useful error when the frame is missing (Kohei Ueno) #42776
[dc3b91f351] - deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262
[35250bf2f6] - deps: regenerate OpenSSL archs files (Daniel Bevenius) #42973
[ecacc3a727] - deps: exclude linker scripts for windows builds (Daniel Bevenius) #42973
[41fdc2617d] - deps: upgrade npm to 8.11.0 (npm team) #43210
[87b248e27e] - deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197
[d42de132a7] - deps: upgrade npm to 8.10.0 (npm team) #43061
[0000654e47] - deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
[742ffefb44] - (SEMVER-MINOR) deps: make V8 10.2 ABI-compatible with 10.1 (Michaël Zasso) #42740
[c626a533c7] - deps: make V8 compilable with older glibc (Michaël Zasso) #42657
[76546b12a2] - deps: V8: fix v8-cppgc.h for MSVC (Jiawen Geng) #42657
[45e1fd4473] - deps: silence V8's warning on CompileFunction (Michaël Zasso) #40907
[2130891a9a] - (SEMVER-MINOR) deps: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488
[e678b6c63d] - deps: fix V8 build issue with inline methods (Jiawen Geng) #38807
[f83323f304] - deps: V8: forward declaration of Rtl*FunctionTable (Refael Ackermann) #32116
[4be7584ca6] - deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116
[b3c8e609fd] - (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
[0afdc3e9a8] - doc: use serial comma in errors docs (Tobias Nießen) #43242
[00989338b3] - doc: add note regarding %Array.prototype.concat% in primordials.md (Antoine du Hamel) #43166
[badf72dd0a] - doc: use serial comma in worker_threads docs (Tobias Nießen) #43220
[776e746f0a] - doc: fix napi version for node_api_symbol_for (Danielle Adams) #42878
[76b46801f8] - doc: document signal option for EventTarget#addEventListener (Antoine du Hamel) #43170
[3082c75efd] - doc: make minor adjustments (LiviaMedeiros) #43175
[598c1f102e] - doc: use serial comma in dgram docs (Tobias Nießen) #43191
[b772c13a62] - doc: use serial comma in process docs (Tobias Nießen) #43179
[f90a3d7a54] - doc: improved parallel specification (mawaregetsuka) #42679
[71074eedef] - doc: improve callback params for fs.mkdir (Daeyeon Jeong) #43016
[2b8b224077] - doc: remove outdated footnote (Python 2 --> 3 for V8 tests) (DeeDeeG) #43105
[945f228cf1] - doc: add release key for RafaelGSS (Rafael Gonzaga) #43131
[56fc712f93] - doc: use serial comma in assert docs (Tobias Nießen) #43154
[093a3cf2f1] - doc: fix errors in Performance hooks doc (OneNail) #43152
[4d9f43a8a7] - doc: use serial comma in dns docs (Tobias Nießen) #43145
[4e9393e32f] - doc: use ASCII apostrophes consistently (Tobias Nießen) #43114
[b3181851d7] - doc: add strategic initiative for shadow realm (Chengzhong Wu) #43037
[6f48dfb499] - fs: add trailing commas (LiviaMedeiros) #43127
[3e89b7336d] - (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
[9539cfa358] - (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
[b187060f76] - http2: set origin name correctly when servername is empty (ofirbarak) #42838
[a07f5f28f3] - http2: improve tests and docs (Daeyeon Jeong) #42858
[701d40496d] - lib: refactor validateInt32 and validateUint32 (mawaregetsuka) #43071
[09da76493a] - meta: update AUTHORS (Node.js GitHub Bot) #43231
[1da6b7c32b] - meta: add mailmap entry for legendecas (Chengzhong Wu) #43156
[1be254b24e] - meta: add mailmap entry for npm team (Luigi Pinca) #43143
[7d8d9d625a] - meta: add mailmap entry for Morgan Roderick (Luigi Pinca) #43144
[8f5b4570e5] - (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
[11c783fa63] - net: remoteAddress always undefined called before connected (OneNail) #43011
[9c4e070567] - (SEMVER-MINOR) node-api: emit uncaught-exception on unhandled tsfn callbacks (Chengzhong Wu) #36510
[54d68b1afd] - perf_hooks: fix start_time of perf_hooks (theanarkh) #43069
[baa5d0005a] - src: refactor GetCipherValue and related functions (Tobias Nießen) #43171
[6ee9fb14e4] - src: make SecureContext fields private (Tobias Nießen) #43173
[1e2552ba6c] - src: reuse GetServerName (Tobias Nießen) #43168
[d8a14a2486] - src: fix static analysis warning and use smart ptr (Tobias Nießen) #43117
[72a767b7ca] - src: remove SecureContext::operator* (Tobias Nießen) #43121
[82fb037388] - src: move context snapshot index to SnapshotData (Joyee Cheung) #43023
[9577878258] - src: replace TraceEventScope with sync events (Chengzhong Wu) #42977
[41b69e3cf4] - src,lib: migrate to console on context's extra binding (Chengzhong Wu) #43142
[3e1ed1ee0c] - test: improve code coverage for inspector connection errors (Kohei Ueno) #42310
[d7ca2234dc] - test: use mustSucceed instead of mustCall with assert.ifError (MURAKAMI Masahiko) #43188
[9cc5ce6a24] - test: improve readline/emitKeypressEvents.js coverage (OneNail) #42908
[447bbd0d66] - tls: fix convertALPNProtocols accepting ArrayBufferViews (LiviaMedeiros) #43211
[df691464aa] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43230
[d9fb25c936] - tools: refactor build-addons.js to ESM (Feng Yu) #43099
[0efeceb4a6] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43172
[ed352a945c] - tools: update eslint to 8.16.0 (Node.js GitHub Bot) #43174
[1183058908] - tools: refactor update-authors.js to ESM (Feng Yu) #43098
[5228028962] - (SEMVER-MINOR) tools: update V8 gypfiles for 10.2 (Michaël Zasso) #42740
[d6cf409d78] - (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
[d91b489784] - worker: fix heap snapshot crash on exit (Chengzhong Wu) #43123

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. [email protected],[email protected],[email protected] CC=[email protected] Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Michael Starzinger <[email protected]> Commit-Queue: Tamer Tas <[email protected]> Cr-Commit-Position: refs/heads/master@{#59045} Refs: v8/v8@bd019bd PR-URL: #32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Co-Authored-By: Richard Lau <[email protected]>

This should be semver-patch since actual invocation is version conditional. PR-URL: #32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

PR-URL: #35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Remove call to `memfd_create`. The function that references it is only used for V8 testing. PR-URL: #42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Create an unused deopt kind to replace `DeoptimizeKind::kSoft`, which was removed. This ensures that the layout of IsolateData doesn't change. Refs: v8/v8@1ff685d PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This reverts commit 35d72bf. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Refs: v8/v8@10.2.154.2...10.2.154.4 PR-URL: #43067 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>

According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>

PR-URL: #43037 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Also added comments for the members of SnapshotData and renamed blob to v8_snapshot_blob_data for clarity. PR-URL: #43023 Fixes: #31074 Refs: #35711 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Since V8 code cache encodes indices to the read-only space it is safer to make sure that the code cache is generated in the same heap used to generate the embdded snapshot. This patch merges the code cache builder into the snapshot builder and makes the code cache part of node::SnapshotData that is deserialized into the native module loader during bootstrap. PR-URL: #43023 Fixes: #31074 Refs: #35711 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

This change allows passing objects as "named parameters": - `fs.write(fd, buffer[, options], callback)` - `fs.writeSync(fd, buffer[, options])` - `filehandle.write(buffer[, options])` Fixes: #41666 PR-URL: #42601 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #43114 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

PR-URL: #43127 Co-authored-by: Antoine du Hamel <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>

Coverity issues a warning about `value_before_reset == ca`, where value_before_reset is a pointer that may not be valid. While comparing the pointer itself should still work, we should really be using smart pointers here so that this particular check can be simplified without running into a memory leak. Refactor SSL_CTX_get_issuer to return a smart pointer and update the call sites accordingly. Note that we might have to change that in the future once we improve error handling throughout crypto/tls. Refs: #37990 PR-URL: #43117 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

PR-URL: #43061 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

Refs: #11321 Refs: #17384 PR-URL: #43145 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

PR-URL: #43144 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: #43011 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Worker.parent_port_ can be released before the exit event of Worker. The parent_port_ is not owned by `node::worker::Worker`, thus the reference to it is not always valid, and accessing it at exit crashes the process. As the Worker.parent_port_ is only used in the memory info tracking, it can be safely removed. PR-URL: #43123 Fixes: #43122 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #43143 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

PR-URL: #43152 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>

bengl · 2022-06-01T13:11:35Z

@ruyadorno Changed it.

@targos If you could double-check that I've got the semver status of the V8 commits correctly, that would be great! 😄

bengl · 2022-06-01T18:37:34Z

@mcollina I think since #43262 hasn't landed, it's going to have to go into a future release. Sorry!

mcollina · 2022-06-01T18:46:24Z

I don't have much luck against the flaky CI.

FYI that release shipped a very important feature for fetch.

PR-URL: #43262 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266

bengl · 2022-06-01T22:44:33Z

I've added #43262 as per @mcollina's request.

New CI: https://ci.nodejs.org/job/node-test-pull-request/44307/
New CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2948/

If all goes well, I'll promote this tonight.

mcollina

lgtm

nodejs-github-bot · 2022-06-02T00:00:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44309/

PR-URL: #43266

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266

Refs: nodejs/node#43266

targos · 2022-06-02T07:50:26Z

@targos If you could double-check that I've got the semver status of the V8 commits correctly, that would be great! 😄

Belated LGTM

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) nodejs#43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) nodejs#42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * deps: upgrade npm to 8.11.0 (npm team) nodejs#43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) nodejs#43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) nodejs#42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) nodejs#42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) nodejs#43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [nodejs#42740](nodejs#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: nodejs#43266

targos and others added 30 commits May 23, 2022 16:29

deps: update V8 to 10.2.154.2

b3c8e60

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

build: reset embedder string to "-node.0"

b8b5e6d

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

deps: V8: forward declaration of Rtl*FunctionTable

f83323f

This should be semver-patch since actual invocation is version conditional. PR-URL: #32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

deps: disable trap handler for Windows cross-compiler

2130891

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>

deps: silence V8's warning on CompileFunction

45e1fd4

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

tools: update V8 gypfiles for 10.2

5228028

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

build: run V8 tests with detected Python version

d663470

V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Revert "build: make x86 Windows support temporarily experimental"

5eff7b4

This reverts commit 35d72bf. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

src: remove SecureContext::operator*

72a767b

This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

fs: add trailing commas

6f48dfb

PR-URL: #43127 Co-authored-by: Antoine du Hamel <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>

deps: upgrade npm to 8.10.0

d42de13

PR-URL: #43061 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

doc: use serial comma in dns docs

4d9f43a

Refs: #11321 Refs: #17384 PR-URL: #43145 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

meta: add mailmap entry for Morgan Roderick

7d8d9d6

PR-URL: #43144 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

net: remoteAddress always undefined called before connected

11c783f

PR-URL: #43011 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

meta: add mailmap entry for npm team

1be254b

PR-URL: #43143 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

doc: fix errors in Performance hooks doc

093a3cf

PR-URL: #43152 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>

This comment was marked as outdated.

Sign in to view

bengl requested review from targos and a team June 1, 2022 18:25

richardlau approved these changes Jun 1, 2022

View reviewed changes

ruyadorno approved these changes Jun 1, 2022

View reviewed changes

BethGriggs approved these changes Jun 1, 2022

View reviewed changes

nodejs-github-bot and others added 2 commits June 1, 2022 18:28

deps: update undici to 5.4.0

dc3b91f

PR-URL: #43262 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

bengl force-pushed the v18.3.0-proposal branch from 7a2ee56 to 49362ef Compare June 1, 2022 22:36

This comment was marked as outdated.

Sign in to view

mcollina approved these changes Jun 1, 2022

View reviewed changes

github-actions bot mentioned this pull request Jun 2, 2022

CI Reliability 2022-06-02 nodejs/reliability#296

Open

19 tasks

RafaelGSS approved these changes Jun 2, 2022

View reviewed changes

bengl merged commit 49362ef into v18.x Jun 2, 2022

bengl added a commit that referenced this pull request Jun 2, 2022

Working on v18.3.1

bb34a5b

PR-URL: #43266

bengl added a commit to nodejs/nodejs.org that referenced this pull request Jun 2, 2022

Blog: v18.3.0 release post

fdac2b7

Refs: nodejs/node#43266

bengl mentioned this pull request Jun 2, 2022

Blog: v18.3.0 release post nodejs/nodejs.org#4632

Merged

bengl added a commit to nodejs/nodejs.org that referenced this pull request Jun 2, 2022

Blog: v18.3.0 release post

35d96fd

Refs: nodejs/node#43266

bengl deleted the v18.3.0-proposal branch June 2, 2022 04:14

This was referenced Jun 3, 2022

CI Reliability 2022-06-03 nodejs/reliability#297

Open

CI Reliability 2022-06-04 nodejs/reliability#298

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v18.3.0 proposal #43266

v18.3.0 proposal #43266

bengl commented May 31, 2022 •

edited

Loading

bengl commented Jun 1, 2022

This comment was marked as outdated.

This comment was marked as outdated.

bengl commented Jun 1, 2022

mcollina commented Jun 1, 2022 •

edited

Loading

This comment was marked as outdated.

bengl commented Jun 1, 2022

mcollina left a comment

nodejs-github-bot commented Jun 2, 2022

targos commented Jun 2, 2022

v18.3.0 proposal #43266

v18.3.0 proposal #43266

Conversation

bengl commented May 31, 2022 • edited Loading

2022-05-31, Version 18.3.0 (Current), @bengl

Notable Changes

Commits

bengl commented Jun 1, 2022

This comment was marked as outdated.

This comment was marked as outdated.

bengl commented Jun 1, 2022

mcollina commented Jun 1, 2022 • edited Loading

This comment was marked as outdated.

bengl commented Jun 1, 2022

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jun 2, 2022

targos commented Jun 2, 2022

bengl commented May 31, 2022 •

edited

Loading

mcollina commented Jun 1, 2022 •

edited

Loading