lib: refactor transferable AbortSignal #43388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of makeTransferable on all AbortSignal instances made creating them always slow, causing bottlenecks in stuff like Web Streams. This refactors that so that AbortSignals are not transferable by default, which is actually the correct standard behavior anyway. A new transferableAbortSignal and transferableAbortController utility is provided to enable the transferable use case. Signed-off-by: James M Snell <[email protected]>
nodejs-github-bot
added
needs-ci
ronag
approved these changes
Jun 12, 2022
benjamingr
approved these changes
Jun 12, 2022
|
Note the failing tests |
ronag
approved these changes
Jun 12, 2022
RaisinTen
reviewed
Jun 13, 2022
| <!-- | ||
| added: REPLACEME | ||
| --> | ||
|
|
There was a problem hiding this comment.
Suggested change
| > Stability: 1 - Experimental | |
| <!-- | ||
| added: REPLACEME | ||
| --> | ||
|
|
There was a problem hiding this comment.
Suggested change
| > Stability: 1 - Experimental | |
| * }} [init] | ||
| * @returns {AbortSignal} | ||
| */ | ||
| function createAbortSignal(init) { |
There was a problem hiding this comment.
Suggested change
| function createAbortSignal(init) { | |
| function createAbortSignal(init = kEmptyObject) { |
and then requiring kEmptyObject from internal/util will probably fix the test failures. You might also want to rebase to include the change from #43159 for this to work.
This was referenced Jun 14, 2022
|
Superseded by #44048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of makeTransferable on all AbortSignal instances made creating them always slow,
causing bottlenecks in stuff like Web Streams. This refactors that so that AbortSignals
are not transferable by default, which is actually the correct standard behavior anyway.
A new transferableAbortSignal and transferableAbortController utility is provided to
enable the transferable use case.
Signed-off-by: James M Snell [email protected]
Fixes: #43160
/cc @mcollina @ronag