Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: fix setSimultaneousAccepts #43951

Closed
wants to merge 1 commit into from

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jul 22, 2022

The error from CI is as follows. When pass the pipe handle by IPC on win32, the bug will be triggered because setSimultaneousAccepts is only defined on tcp handle. In addition, setSimultaneousAccepts should only be valid on tcp server.

error Message
fail (1)
Stacktrace
node:internal/child_process:821
        handle.setSimultaneousAccepts(true);
               ^

TypeError: handle.setSimultaneousAccepts is not a function
    at target._send (node:internal/child_process:821:16)
    at target.send (node:internal/child_process:738:19)
    at sendHelper (node:internal/cluster/utils:28:15)
    at RoundRobinHandle.handoff (node:internal/cluster/round_robin_handle:128:3)
    at RoundRobinHandle.distribute (node:internal/cluster/round_robin_handle:108:10)
    at handle.onconnection (node:internal/cluster/round_robin_handle:45:54)
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 22, 2022
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a test?

lib/internal/child_process.js Outdated Show resolved Hide resolved
lib/internal/child_process.js Outdated Show resolved Hide resolved
@theanarkh theanarkh force-pushed the fix_setSimultaneousAccepts branch 6 times, most recently from dd49d1e to 21cae86 Compare July 23, 2022 08:17
@nodejs-github-bot
Copy link
Collaborator

@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants