src,lib: print prinstine source when source map source not found #44052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
force-pushed
the
test-error-source
branch
from
9beec4f
to
4fde82c
Compare
bcoe
approved these changes
Aug 3, 2022
github-actions
bot
removed
the
request-ci
legendecas
commented
Aug 4, 2022
Comment on lines
+149
to
+151
| if (typeof source !== 'string') { | ||
| return; | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Landed in 0a2c910 |
legendecas
added a commit
that referenced
this pull request
Aug 6, 2022
Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent. PR-URL: #44052 Refs: #44019 Reviewed-By: Ben Coe <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent. PR-URL: #44052 Refs: #44019 Reviewed-By: Ben Coe <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent. PR-URL: #44052 Refs: #44019 Reviewed-By: Ben Coe <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent. PR-URL: nodejs#44052 Refs: nodejs#44019 Reviewed-By: Ben Coe <[email protected]>
|
This depends on #43875 to be landed in v16.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent.
Refs: #44019