Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: prevent copying ArrayBufferViewContents #44091

Merged
merged 2 commits into from
Aug 6, 2022
Merged

src: prevent copying ArrayBufferViewContents #44091

merged 2 commits into from
Aug 6, 2022

Commits on Aug 2, 2022

  1. src: prevent copying ArrayBufferViewContents 

    It is error-prone to copy or heap-allocate `ArrayBufferViewContents`,
because you might accidentally cause it to exceed the lifetime of its
argument. Let's make it impossible to do so. Fortunately we were not
doing so anywhere already, so this diff is purely defensive.

Refs: nodejs#44079 (comment)
    @kvakil
    kvakil committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    d1f3368 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. fixup! src: prevent copying ArrayBufferViewContents

    @kvakil
    kvakil committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    d0522f5 View commit details
    Browse the repository at this point in the history