Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: various fixes to the debugger and the debugger tests #44359

Merged
merged 3 commits into from
Aug 24, 2022
Merged

debugger: various fixes to the debugger and the debugger tests #44359

merged 3 commits into from
Aug 24, 2022

Commits on Aug 24, 2022

  1. debugger: decrease timeout used to wait for the port to be free 

    By default, the debugger would query the specified inspector
sever port to see if it's available before starting the server,
and it would keep retrying until a timeout (previously 9999 ms)
is reached. This timeout seems to be longer than necessary. This
patch decreases the timeout to 3 seconds.
    @joyeecheung
    joyeecheung committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    2ac729f View commit details
    Browse the repository at this point in the history

  2. debugger: end connections used to check availability of the port 

    The debugger check the availability of the specified inspector server
port by trying to connect to it, and retry if the connection can be
established (which means the port is not yet free), but it never ends
those connections. This patch adds code to end the connections after
they are established to avoid taking up more resources than necessary.
    @joyeecheung
    joyeecheung committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e123a52 View commit details
    Browse the repository at this point in the history

  3. test: increase timeout in the debugger tests on Windows 

    On certain Windows machines it may take longer for the testing
processes to receive outputs from the debugger process. Increasing
the timeout to 15 seconds to avoid failing the tests in those
cases.
    @joyeecheung
    joyeecheung committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f7b0721 View commit details
    Browse the repository at this point in the history