Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake child process exec timeout tests #44390

Closed
wants to merge 1 commit into from
Closed

test: deflake child process exec timeout tests #44390

wants to merge 1 commit into from

Commits on Aug 25, 2022

  1. test: deflake child process exec timeout tests 

    On Windows it might take too long for the parent to start the
communication with a child process, so by the time the parent
starts its own timer, the child process might have already
completed running, and the parent in those tests won't have a
chance to terminate these child processes after the timeout.
To address this issue, raise the time for which the child is
supposed to run to make sure that the parent starts
its own timer before the child terminates in the tests.
Also, split the test into smaller ones to reduce the overhead.
    @joyeecheung
    joyeecheung committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    a556388 View commit details
    Browse the repository at this point in the history