deps: V8: backport ff8d67c88449 #44423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
Reland "Fix Context PromiseHook behaviour with debugger enabled"
This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
Original change's description:
> Fix Context PromiseHook behaviour with debugger enabled
>
> This is a solution for nodejs#43148.
>
> Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
>
> Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
> Reviewed-by: Victor Gomes <[email protected]>
> Commit-Queue: Camillo Bruni <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#82132}
Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82575}
Refs: v8/v8@ff8d67c
Fixes: nodejs#43148
Fixes: nodejs#44415
|
Review requested:
|
nodejs-github-bot
added
build
bnoordhuis
approved these changes
Aug 28, 2022
Qard
approved these changes
Aug 28, 2022
jasnell
approved these changes
Aug 28, 2022
cjihrig
approved these changes
Aug 28, 2022
gengjiawen
approved these changes
Aug 29, 2022
This was referenced Aug 31, 2022
Flarna
approved these changes
Sep 1, 2022
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 767a78a |
24 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
Original commit message:
Reland "Fix Context PromiseHook behaviour with debugger enabled"
This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
Original change's description:
> Fix Context PromiseHook behaviour with debugger enabled
>
> This is a solution for #43148.
>
> Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
>
> Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
> Reviewed-by: Victor Gomes <[email protected]>
> Commit-Queue: Camillo Bruni <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#82132}
Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82575}
Refs: v8/v8@ff8d67c
Fixes: #43148
Fixes: #44415
PR-URL: #44423
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 6, 2022
Original commit message:
Reland "Fix Context PromiseHook behaviour with debugger enabled"
This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
Original change's description:
> Fix Context PromiseHook behaviour with debugger enabled
>
> This is a solution for #43148.
>
> Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
>
> Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
> Reviewed-by: Victor Gomes <[email protected]>
> Commit-Queue: Camillo Bruni <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#82132}
Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82575}
Refs: v8/v8@ff8d67c
Fixes: #43148
Fixes: #44415
PR-URL: #44423
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 7, 2022
Original commit message:
Reland "Fix Context PromiseHook behaviour with debugger enabled"
This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
Original change's description:
> Fix Context PromiseHook behaviour with debugger enabled
>
> This is a solution for #43148.
>
> Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
>
> Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
> Reviewed-by: Victor Gomes <[email protected]>
> Commit-Queue: Camillo Bruni <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#82132}
Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82575}
Refs: v8/v8@ff8d67c
Fixes: #43148
Fixes: #44415
PR-URL: #44423
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Original commit message:
Reland "Fix Context PromiseHook behaviour with debugger enabled"
This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
Original change's description:
> Fix Context PromiseHook behaviour with debugger enabled
>
> This is a solution for nodejs#43148.
>
> Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
>
> Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
> Reviewed-by: Victor Gomes <[email protected]>
> Commit-Queue: Camillo Bruni <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#82132}
Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82575}
Refs: v8/v8@ff8d67c
Fixes: nodejs#43148
Fixes: nodejs#44415
PR-URL: nodejs#44423
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@ff8d67c
Fixes: #43148
Fixes: #44415