Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: fix non-string header value concatenation #4460

Closed
wants to merge 1 commit into from
Closed

http: fix non-string header value concatenation #4460

wants to merge 1 commit into from

Commits on Dec 28, 2015

  1. http: fix non-string header value concatenation 

    Since headers are stored in an empty literal object ({}) instead
of an object created with Object.create(null), care must be taken
with property names inherited from Object. Currently there are
only functions inherited, so we can safely check for existing
strings instead.

Fixes: nodejs#4456
    @mscdex
    mscdex committed Dec 28, 2015
    Configuration menu
    Copy the full SHA
    070b617 View commit details
    Browse the repository at this point in the history