Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change promise to async/await in test-debugger-help.mjs #44686

Merged
merged 1 commit into from
Sep 29, 2022
Merged

test: change promise to async/await in test-debugger-help.mjs #44686

merged 1 commit into from
Sep 29, 2022

Conversation

chanduMe
Copy link
Contributor

Changes:

  1. Updated the test-debugger-help.js to test-debugger-help.mjs
  2. Updated the test-debugger-help to use async/await instead of a promise.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 16, 2022
@Trott
Copy link
Member

Trott commented Sep 18, 2022

Welcome @chanduMe and thanks for the pull request. Can you please update the commit message to conform with our requirements? The first line needs to be 5 characters shorter so may this?:

test: use async/await in test-debugger-help

@Trott Trott force-pushed the test-debugger-help-promist-to-async branch from 2ea966c to 8dab888 Compare September 19, 2022 20:47
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46663/

@github-actions github-actions bot mentioned this pull request Sep 20, 2022
Open
11 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46776/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46788/

This was referenced Sep 26, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46852/

This was referenced Sep 28, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46914/

@MoLow MoLow mentioned this pull request Sep 30, 2022
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46938/

@Trott
Copy link
Member

Trott commented Sep 29, 2022

I'm not sure why the macOS test system keeps failing on Jenkins, but I'm going to rebase and force-push in the hope that there's a fix in the code base somewhere that we just need to include here.

@Trott Trott force-pushed the test-debugger-help-promist-to-async branch from 8dab888 to e3118ea Compare September 29, 2022 18:39
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@richardlau
Copy link
Member

I'm not sure why the macOS test system keeps failing on Jenkins, but I'm going to rebase and force-push in the hope that there's a fix in the code base somewhere that we just need to include here.

sequential/test-watch-mode-inspect failed. It's not as obvious in Jenkins anymore because the Node.js tap runner means we end up with tap embedded within tap which requires fixes in https://github.com/nodejs/tap2junit -- I'm waiting for a new version to be released (nodejs/tap2junit#41) so I can (easily) deploy the update onto the test infrastructure.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46943/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46949/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit e236af8 into nodejs:main Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e236af8

@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Open
17 tasks
@Trott
Copy link
Member

Trott commented Sep 30, 2022

Thanks for the contribution! 🎉

This was referenced Oct 1, 2022
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@chanduMe @danielleadams
test: use async/await in test-debugger-help
9f14625 
PR-URL: #44686
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chanduMe @Trott @nodejs-github-bot @richardlau