test: change promises to async/await in test-debugger-heap-profiler #44693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
nodejs-github-bot
added
needs-ci
Qard
reviewed
Sep 17, 2022
Trott
force-pushed
the
brinda-patch-test
branch
from
27e8e91
to
3f61a3e
Compare
Trott
approved these changes
Sep 25, 2022
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
This was referenced Sep 26, 2022
This was referenced Sep 28, 2022
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44693 ✔ Done loading data for nodejs/node/pull/44693 ----------------------------------- PR info ------------------------------------ Title test: change promises to async/await in test-debugger-heap-profiler (#44693) Author Brinda Ashar (@brindashar4, first-time contributor) Branch brindashar4:brinda-patch-test -> nodejs:main Labels test, code-and-learn, author ready, needs-ci Commits 1 - test: use async/await in test-debugger-heap-profiler Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/44693 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44693 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Sep 2022 21:58:29 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44693#pullrequestreview-1119430727 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-29T06:27:04Z: https://ci.nodejs.org/job/node-test-pull-request/46919/ - Querying data for job/node-test-pull-request/46919/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @brindashar4([email protected]) ⚠ - commit 3f61a3e1fabd is authored by [email protected] -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3152126664 |
PR-URL: nodejs#44693 Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
brinda-patch-test
branch
from
3f61a3e
to
865a578
Compare
|
Landed in 865a578 |
|
Thanks for the contribution! 🎉 |
This was referenced Sep 30, 2022
14 tasks
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44693 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.