Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update node prefix require.cache example #44724

Merged
merged 1 commit into from
Oct 2, 2022
Merged

doc: update node prefix require.cache example #44724

merged 1 commit into from
Oct 2, 2022

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Sep 19, 2022

I think it would be more intuitive if the docs showed passing assertions

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Sep 19, 2022
@ljharb ljharb mentioned this pull request Sep 19, 2022
Closed
RaisinTen
RaisinTen approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using fix instead of update in the title sounds more appropriate IMO because the previous code is incorrect as it runs into an assertion error

@daeyeon daeyeon added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2022
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8f16a8c into nodejs:main Oct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8f16a8c

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@simoneb @danielleadams
doc: update node prefix require.cache example
7c5c19e 
PR-URL: #44724
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@simoneb @nodejs-github-bot @jasnell @GeoffreyBooth @lpinca @tniessen @marsonya @RaisinTen @daeyeon