Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include last security release date #44794

Merged
merged 2 commits into from
Oct 2, 2022
Merged

doc: include last security release date #44794

merged 2 commits into from
Oct 2, 2022

Conversation

vdeturckheim
Copy link
Member

Ref. 7e0097d

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@vdeturckheim vdeturckheim marked this pull request as ready for review September 26, 2022 08:30
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 26, 2022
mhdawson
mhdawson approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@vdeturckheim many thanks!

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/44794
✔  Done loading data for nodejs/node/pull/44794
----------------------------------- PR info ------------------------------------
Title      doc: include last security release date (#44794)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     vdeturckheim:master -> nodejs:main
Labels     doc
Commits    2
 - doc: include last security release date
 - Update doc/contributing/security-release-process.md
Committers 2
 - Vladimir de Turckheim 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/44794
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44794
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 26 Sep 2022 08:30:38 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44794#pullrequestreview-1120734169
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44794#pullrequestreview-1120742370
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/44794#pullrequestreview-1120790967
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/44794#pullrequestreview-1121026499
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44794#pullrequestreview-1127612943
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 44794
From https://github.com/nodejs/node
 * branch                  refs/pull/44794/merge -> FETCH_HEAD
✔  Fetched commits as ce59abceb41c..6a424811d566
--------------------------------------------------------------------------------
[main 7a92b6a3cb] doc: include last security release date
 Author: Vladimir de Turckheim 
 Date: Mon Sep 26 10:29:31 2022 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
[main 51aaa05a34] Update doc/contributing/security-release-process.md
 Author: Vladimir de Turckheim 
 Date: Mon Sep 26 10:33:48 2022 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: include last security release date


PR-URL: #44794

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Tobias Nießen [email protected]

Reviewed-By: Michael Dawson [email protected]

Reviewed-By: Trivikram Kamat [email protected]

Reviewed-By: James M Snell [email protected]


[detached HEAD c195a1dabe] doc: include last security release date

Author: Vladimir de Turckheim [email protected]

Date: Mon Sep 26 10:29:31 2022 +0200

1 file changed, 2 insertions(+), 2 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/contributing/security-release-process.md


PR-URL: #44794

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Tobias Nießen [email protected]

Reviewed-By: Michael Dawson [email protected]

Reviewed-By: Trivikram Kamat [email protected]

Reviewed-By: James M Snell [email protected]


[detached HEAD 3fd664055b] Update doc/contributing/security-release-process.md

Author: Vladimir de Turckheim [email protected]

Date: Mon Sep 26 10:33:48 2022 +0200

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/3168011168

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit dc96633 into nodejs:main Oct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in dc96633

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@vdeturckheim @danielleadams
doc: include last security release date
2a5bce6 
PR-URL: #44794
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@mhdawson mhdawson mhdawson approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vdeturckheim @nodejs-github-bot @mhdawson @jasnell @lpinca @tniessen @trivikr @mcollina