Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: remove runtime experimental warning #44844

Merged
merged 1 commit into from
Oct 3, 2022
Merged

test_runner: remove runtime experimental warning #44844

merged 1 commit into from
Oct 3, 2022

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 30, 2022

This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read.

@cjihrig
test_runner: remove runtime experimental warning
a8432fa 
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 30, 2022
@tniessen
Copy link
Member

tniessen commented Oct 1, 2022

±0 as long as it remains experimental. (If it's just in the docs, it's easy to ignore, so if we later break the test runner, it might make users who rely on it unhappy.)

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 1, 2022

A couple notes:

  • It would definitely still be considered experimental. I also think we should try to avoid breaking changes to the test runner at this point.
  • Currently, the warning is emitted for every test file. When using the CLI runner with many files, this can get noisy if there are failures across several files. Fortunately, this only shows up for tests with failures, but...
  • There is ongoing work to add a TAP parser which would ideally surface user output to both stdout and stderr, which would make the current behavior noisy even if nothing fails.
  • There is prior art for dropping the runtime warning when it interferes with the usability of the feature. I'm thinking of util.parseArgs() specifically, but there are probably others.

@MoLow MoLow added test_runner Issues and PRs related to the test runner subsystem. dont-land-on-v14.x and removed test Issues and PRs related to the tests. labels Oct 2, 2022
@MoLow MoLow mentioned this pull request Oct 2, 2022
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47011/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47033/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47042/

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit ad8442f into nodejs:main Oct 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ad8442f

TimShilov pushed a commit to TimShilov/node that referenced this pull request Oct 3, 2022
@cjihrig @TimShilov
test_runner: remove runtime experimental warning
794d320 
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.

PR-URL: nodejs#44844
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 4, 2022
Open
16 tasks
panva pushed a commit to panva/node that referenced this pull request Oct 4, 2022
@cjihrig @panva
test_runner: remove runtime experimental warning
61ae3b2 
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.

PR-URL: nodejs#44844
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 5, 2022
Open
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@cjihrig @danielleadams
test_runner: remove runtime experimental warning
c7ece46 
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.

PR-URL: #44844
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@cjihrig @MoLow
test_runner: remove runtime experimental warning
1e8a80d 
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.

PR-URL: nodejs#44844
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MoLow MoLow mentioned this pull request Nov 24, 2022
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@cjihrig @MoLow
test_runner: remove runtime experimental warning
3f16e33 
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.

PR-URL: nodejs#44844
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig deleted the remove-warning branch December 30, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @tniessen @nodejs-github-bot @jasnell @MoLow