-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,crypto: add missing algorithms and types to webcrypto documentation #44876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
experimental
Issues and PRs related to experimental features.
webcrypto
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
labels
Oct 3, 2022
cc @nodejs/crypto |
panva
force-pushed
the
webcrypto-doc-fixes
branch
from
October 3, 2022 11:45
8f47f99
to
c30b295
Compare
tniessen
approved these changes
Oct 3, 2022
tniessen
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, messed up the order of comments. The previous comment is the same nit, essentially :)
panva
force-pushed
the
webcrypto-doc-fixes
branch
from
October 3, 2022 11:48
c30b295
to
ffdd070
Compare
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 3, 2022
tniessen
approved these changes
Oct 3, 2022
WaWa738
reviewed
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@
lpinca
approved these changes
Oct 3, 2022
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 5, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 5, 2022
Landed in 3ab2d4f...2f47a5b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
PR-URL: #44876 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
PR-URL: #44876 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44876 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44876 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
experimental
Issues and PRs related to experimental features.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
as an allowed deriveBits length