Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix label name in collaborator guide #44920

Merged
merged 1 commit into from
Oct 8, 2022
Merged

doc: fix label name in collaborator guide #44920

merged 1 commit into from
Oct 8, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 8, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 8, 2022
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6831e2f into main Oct 8, 2022
@nodejs-github-bot nodejs-github-bot deleted the Trott-patch-1 branch October 8, 2022 15:44
@nodejs-github-bot
Copy link
Collaborator

Landed in 6831e2f

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@Trott @danielleadams
doc: fix label name in collaborator guide
ddb5402 
PR-URL: #44920
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cola119 cola119 cola119 approved these changes

@legendecas legendecas legendecas approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @GeoffreyBooth @lpinca @legendecas @cola119