Revert "deps: V8: forward declaration of Rtl*FunctionTable"
#45119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01bc8e6.
|
Review requested:
|
nodejs-github-bot
added
build
|
Don't we allow git-style revert messages? |
7 tasks
github-actions
bot
removed
the
request-ci
gengjiawen
approved these changes
Oct 22, 2022
Sounds like a bug to me, I've sent a PR to fix it: nodejs/core-validate-commit#102. |
|
Windows CI is green! |
cjihrig
approved these changes
Oct 22, 2022
jasnell
approved these changes
Oct 22, 2022
This was referenced Oct 23, 2022
gengjiawen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45119 ✔ Done loading data for nodejs/node/pull/45119 ----------------------------------- PR info ------------------------------------ Title Revert "deps: V8: forward declaration of `Rtl*FunctionTable`" (#45119) Author Michaël Zasso (@targos) Branch targos:revert-rtl -> nodejs:main Labels build, v8 engine, needs-ci Commits 1 - Revert "deps: V8: forward declaration of `Rtl*FunctionTable`" Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/45119 Refs: https://github.com/nodejs/node/issues/45118 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45119 Refs: https://github.com/nodejs/node/issues/45118 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Oct 2022 08:28:52 GMT ✔ Approvals: 3 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45119#pullrequestreview-1151903319 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45119#pullrequestreview-1151981244 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45119#pullrequestreview-1152057526 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-10-22T16:51:58Z: https://ci.nodejs.org/job/node-test-pull-request/47397/ ℹ Last V8 CI on 2022-10-22T09:35:01Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4938/ - Querying data for job/node-test-pull-request/47397/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3317858880 |
RaisinTen
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Reran the lint-commit-message job after releasing nodejs/core-validate-commit#102 and GitHub CI is green now, LGTM.
RaisinTen
removed
the
commit-queue-failed
RaisinTen
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in c6c18a9 |
14 tasks
targos
added
dont-land-on-v14.x
dont-land-on-v18.x
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
This reverts commit 01bc8e6. PR-URL: #45119 Refs: #45118 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
This reverts commit 01bc8e6. PR-URL: #45119 Refs: #45118 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 01bc8e6.
Refs: #45118