crypto: handle unsupported AES ciphers in webcrypto #45321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Nov 5, 2022
panva
added
the
author ready
daeyeon
approved these changes
Nov 5, 2022
addaleax
approved these changes
Nov 5, 2022
tniessen
approved these changes
Nov 6, 2022
codebytere
approved these changes
Nov 6, 2022
18 tasks
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0d7a139 |
17 tasks
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
Refs: electron/electron#36256 PR-URL: nodejs#45321 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Refs: electron/electron#36256 PR-URL: #45321 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Refs: electron/electron#36256 PR-URL: #45321 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Refs: electron/electron#36256 PR-URL: #45321 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Refs: electron/electron#36256 PR-URL: #45321 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Refs: electron/electron#36256 PR-URL: #45321 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Electron's exit (and other runtimes that embed Node.js?) caused by missing ciphers due to use of BoringSSL.
Refs: electron/electron#36256